[pull] main from bootc-dev:main#144
Merged
Merged
Conversation
The 052-test-bli-detection test asserts that Fedora 43+ systems boot without a root= kernel argument (using DPS auto-discovery instead). However, this only works when the install was performed via bootc install to-disk, which creates partitions with DPS type GUIDs. In Packit/gating CI, the system is installed via bootc install to-existing-root on a Testing Farm VM whose partitions were not created with DPS type GUIDs. The test was unconditionally failing in this environment. Fix this by checking for the BCVK_EXPORT environment variable, which is set by xtask when running tests via bcvk (image-mode). When not in image-mode, the test skips since DPS root discovery cannot work on partitions that lack the proper type GUIDs. Fixes: #2123 Assisted-by: OpenCode (Claude Opus 4.6) Signed-off-by: Joseph Marrero Corchado <jmarrero@redhat.com>
`zipl` cannot dynamically read BLS config at boot, and requires the MBR to be updated before. So we set `zipl` as the bootloader for s390x by default. Otherwise, s390x systems cannot reboot into new deployments. We set the ostree parameter after the initial ostree deployement because it fails if called during it. See https://github.com/coreos/coreos-assembler/blob/99bb23e7dfbfa8f1ae8b9bfaca9ff2e6d98c6cba/src/osbuild-manifests/build.common.ipp.yaml#L160-L163 Fixes #2151 Signed-off-by: jbtrystram <jbtrystram@redhat.com>
When mounting a freshly-created filesystem during install, pass -t <fstype> to mount rather than relying on auto-detection. util-linux 2.42 introduced an optimization (commit 8bdc2546d) where libmount reads device properties from the udev database instead of probing the device superblock with libblkid. When mkfs runs inside a container, the udev database is stale for the filesystem type because mkfs does not generate a kernel uevent — udev only re-probes devices on kernel-generated events (such as partition table changes from sfdisk), not on arbitrary block device writes. As a result, the udev database has partition tags (PARTUUID, PARTLABEL) from sfdisk but lacks ID_FS_TYPE. libmount's read_from_udev() returns success after finding those partition tags, so the libblkid direct-probe fallback is never called. Without a filesystem type, mount falls back to iterating /etc/filesystems and /proc/filesystems, which fails for filesystem modules (like xfs with CONFIG_XFS_FS=m) that are not yet loaded. Since bootc already knows the filesystem type (it just ran mkfs), passing -t avoids the auto-detection path entirely. Closes: #2148 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: John Eckersberg <jeckersb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )