[pull] main from openrewrite:main#207
Merged
pull[bot] merged 3 commits intoTheTechOddBug:mainfrom Feb 25, 2026
Merged
Conversation
…ma outside (#6811) The parser incorrectly identified `(` as the tuple's opening paren in expressions like `("a"),` where the parentheses wrap the element and the trailing comma outside creates an implicit single-element tuple. This caused the token index to fall behind the AST position, eventually crashing with `'NoneType' object has no attribute 'value_source'` when parsing string literals in type annotations like `Literal["..."]` later in the file.
…renthesization (#6814) Two fixes in the Python template system: 1. PatternMatchingComparator: Change default fallthrough from `return True` to `return False` so unhandled node types reject matches instead of silently accepting. Add explicit handlers for Empty (sentinel) and ArrayAccess nodes. 2. PlaceholderReplacementVisitor: Auto-wrap substituted expressions in parentheses when they have lower operator precedence than the surrounding context. For example, `template("{a} and {b}")` with `b = x or y` now correctly produces `a and (x or y)` instead of `a and x or y`. Handles Binary, Python Binary, and Unary (not).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )