Skip to content

Conversation

@adriansmares
Copy link
Contributor

Summary

Closes #3840

Changes

  • On Component.FromRequestContext, keep the context values in the new context, but use the lifetime of the component.
  • Use FromRequestContext before UnclaimIDs and UnclaimDownlink.

Testing

Unit testing.

Regressions

Not expected.

Notes for Reviewers

This implementation for FromRequestContext should land in TTSE as well.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added bug Something isn't working c/gateway server This is related to the Gateway Server prio/medium labels Feb 23, 2021
@adriansmares adriansmares added this to the February 2021 milestone Feb 23, 2021
@adriansmares adriansmares self-assigned this Feb 23, 2021
Copy link
Contributor

@htdvisser htdvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansmares adriansmares merged commit 306c018 into v3.11 Feb 23, 2021
@adriansmares adriansmares deleted the fix/3840-unclaim-failure branch February 23, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c/gateway server This is related to the Gateway Server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway Server failed to unclaim downlink path

4 participants