Skip to content

Fix DeviceTimeAns timestamp not corresponding to the specification#5636

Merged
happyRip merged 3 commits into
v3.21from
fix/5586-incorrect-devicetimeans-timestamp
Jul 26, 2022
Merged

Fix DeviceTimeAns timestamp not corresponding to the specification#5636
happyRip merged 3 commits into
v3.21from
fix/5586-incorrect-devicetimeans-timestamp

Conversation

@happyRip
Copy link
Copy Markdown
Member

@happyRip happyRip commented Jul 22, 2022 •
edited
Loading

Summary

Closes #5586

Changes

  • Improved HandleDeviceTimeReq timestamp
  • Reverted the change that made the MAC handler run before the deduplication occurred

Testing

  • Added test cases regarding the improvement
Regressions

n/a

Notes for Reviewers

nil

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@happyRip happyRip linked an issue Jul 22, 2022 that may be closed by this pull request
DeviceTimeAns timestamp is not corresponding to the specification #5586
Closed
4 tasks
@github-actions github-actions Bot added the c/network server This is related to the Network Server label Jul 22, 2022
@happyRip happyRip self-assigned this Jul 22, 2022
@happyRip happyRip added the status/in-progress We're working on it label Jul 22, 2022
@happyRip happyRip force-pushed the fix/5586-incorrect-devicetimeans-timestamp branch 3 times, most recently from 042536d to ba719f5 Compare July 25, 2022 13:09
@happyRip happyRip marked this pull request as ready for review July 25, 2022 13:47
adriansmares
adriansmares reviewed Jul 25, 2022
View reviewed changes
Comment thread pkg/networkserver/mac/device_time.go Outdated
@happyRip happyRip force-pushed the fix/5586-incorrect-devicetimeans-timestamp branch from ba719f5 to 229d214 Compare July 25, 2022 14:35
@happyRip happyRip merged commit 2d1b4e3 into v3.21 Jul 26, 2022
@happyRip happyRip deleted the fix/5586-incorrect-devicetimeans-timestamp branch July 26, 2022 06:14
@happyRip happyRip removed the status/in-progress We're working on it label Jul 27, 2022
happyRip added a commit that referenced this pull request Aug 1, 2022
@happyRip
Fix DeviceTimeAns timestamp not corresponding to the specification (#…
55f3f95 
…5636)
happyRip added a commit that referenced this pull request Aug 9, 2022
@happyRip
Fix DeviceTimeAns timestamp not corresponding to the specification (#…
3eba22e 
…5636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johanstokking johanstokking Awaiting requested review from johanstokking

1 more reviewer

@adriansmares adriansmares adriansmares approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@happyRip happyRip

Labels

c/network server This is related to the Network Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeviceTimeAns timestamp is not corresponding to the specification

2 participants

@happyRip @adriansmares