Skip to content

Comments

Use separate context for Redis mutex unlock#7835

Draft
vlasebian wants to merge 1 commit intov3.35from
fix/separate-context-for-redis-unlock
Draft

Use separate context for Redis mutex unlock#7835
vlasebian wants to merge 1 commit intov3.35from
fix/separate-context-for-redis-unlock

Conversation

@vlasebian
Copy link
Contributor

@vlasebian vlasebian commented Feb 19, 2026

Summary

Change the deferred UnlockMutex call to use context.WithoutCancel(ctx) instead of the main ctx. This ensures the unlock Redis command succeeds even if the parent context has been cancelled and the lock gets released faster than the expiration time.

Changes

  • Derive a separate context for unlocking the Redis mutex for LockedWatch.

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@github-actions github-actions bot added the compat/db This could affect Database compatibility label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compat/db This could affect Database compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant