Make the default bootstrap column breakpoint sm, not xs#49
Conversation
put back xs for preview, replaced xs with sm for output
|
I think this is a reasonable change @emRae. I'd like to test it out before merging though since there are quite a few changes. |
There was a problem hiding this comment.
Why not just replace all the xs in the markup and call it a day?
There was a problem hiding this comment.
Do you mean this line is unnecessary? Because I don't understand this phrase. Maybe @emRae can give me a hint.
There was a problem hiding this comment.
Sorry, this is a very late response. Once again, thanks for putting together the plugin!
The .replace(/xs/g, "sm") is meant to add the "sm" class to the custom column shortcodes. I wanted to keep the column size "xs" for the visual editor when you were creating your custom columns but output a "sm" class for the shortcode. This was my hack to do that. There may be a much better way.
There was a problem hiding this comment.
Ah, that makes sense! However, I think it might be a little misleading for the output of the visual editor to differ what from the user just created.
This line was removed before I merged your changes, but I would be happy to consider an alternative solution. Perhaps an "improved" visual editor which makes it more clear what is going to go in the page, or gives the user the real-estate needed to see those sm breakpoints without needing to swap them out after-the-fact.
Thanks again for submitting these changes @emRae
3 participants
Hello,
Thank you for putting this plugin together. In using it the one fatal flaw I noticed is that the default breakpoint class size is set to xs. I believe more people would like their columns to go to 100% width for phone / small devices than have them keep their original width.
The changes I made will switch the default breakpoint class size to sm, instead of xs. IMO, this makes the columns more responsive friendly.
Thanks,
:: Rachel