WL-0MO6ZDLJ5001JUQN: Prevent dialog keystroke passthrough#1585
Merged
Conversation
added 2 commits
April 21, 2026 09:30
…when textarea is focused; add integration test
Member
Author
All CI checks are passingThis PR is ready for review. Posted automatically by AMPA PR Monitor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\nPrevent app-level global shortcuts from acting on printable keystrokes when multi-line dialog textareas are focused. This fixes WL-0MO6ZDLJ5001JUQN where typing 'x' into the Create dialog description closed the Close dialog.\n\nChanges:\n- Tightened the global close-key handler guard in src/tui/controller.ts to avoid firing when dialogs/overlays are open.\n- Added an integration test ensuring 'x' does not open the Close dialog when typing into the create dialog textarea.\n\nTest plan:\n- Ran full test suite locally: all tests passed.\n- Manual verification: open Create dialog, focus description, type printable characters — they are inserted and no dialogs open.\n\nWork items:\n- Fix tracked in WL-0MO6ZDLJ5001JUQN.\n- Related refactor task: WL-0MO998PTZ009EK6U (Centralize modal guard).\n\nNotes:\n- This PR is intentionally small and surgical. A follow-up refactor will centralize the modal guard for global shortcuts (see WL-0MO998PTZ009EK6U).\n\nCommit: 7df809e