Add error toast (red background, 3× duration) for copy command failures#927
Merged
SorraTheOrc merged 2 commits intomainfrom Mar 12, 2026
Merged
Add error toast (red background, 3× duration) for copy command failures#927SorraTheOrc merged 2 commits intomainfrom
SorraTheOrc merged 2 commits intomainfrom
Conversation
Co-authored-by: SorraTheOrc <250240+SorraTheOrc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add error toast for system errors
Add error toast (red background, 3× duration) for copy command failures
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy failures (e.g. xclip not installed) were visually indistinguishable from successes — both used the same green toast. Error conditions now render a distinct red toast that stays visible 3× longer.
Changes
ToastComponent— addsshowError(message)method; extracts shared display logic into_showWithOptions()which handles per-call background override and restoration after hidecontroller.ts— addsshowErrorToast()alongsideshowToast();copySelectedId()now routes all failure paths throughshowErrorToast()instead ofshowToast()test-utils.ts— mocktoastandtoastComponentexposeshowError()andlastIsError()for test assertionscopy-id.test.ts— assertslastIsError() === falseon success and=== truewhen a failure message is producedOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.