Skip to content

ge-hch.5.15.17: add embedding service tests #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SorraTheOrc merged 3 commits into from
Jan 18, 2026
Merged

ge-hch.5.15.17: add embedding service tests #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4d673
ge-hch.5.15.17: add embedding service unit tests
SorraTheOrc Jan 18, 2026
4d55a3c
bd sync: 2026-01-17 20:19:45
SorraTheOrc Jan 18, 2026
4eea376
ge-hch.5.15.17: add node fallback for embedding integration
SorraTheOrc Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .beads/issues.jsonl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
{"id":"ge-hch.5.15.14","title":"Implement: Risk Scorer","description":"Implement computeRiskScore function with 3 active + 3 placeholder metrics.\n\n## Acceptance Criteria\n- [ ] computeRiskScore(proposal, context, config) returns weighted score 0.0-1.0\n- [ ] Implements proposal_confidence_risk: 1.0 - confidence_score\n- [ ] Implements narrative_pacing_risk: based on branch length vs phase\n- [ ] Implements return_path_confidence_risk: from checker\n- [ ] Placeholder metrics return 0.3 default\n- [ ] Configurable weights via config object\n\n## Related Feature\nge-hch.5.15.3 (Risk Scorer)","status":"closed","priority":1,"issue_type":"task","assignee":"@Patch","created_at":"2026-01-16T15:03:35.345472464-08:00","created_by":"rgardler","updated_at":"2026-01-17T16:03:05.124860848-08:00","closed_at":"2026-01-17T16:03:05.124860848-08:00","close_reason":"PR #165 merged","external_ref":"https://github.com/TheWizardsCode/GEngine/pull/165","labels":["Status: PR Created"],"dependencies":[{"issue_id":"ge-hch.5.15.14","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:35.346620476-08:00","created_by":"rgardler"}]}
{"id":"ge-hch.5.15.15","title":"Tests: Risk Scorer","description":"Unit tests for risk scoring.\n\n## Acceptance Criteria\n- [ ] Test: high-confidence proposal (0.9) yields low risk (\u003c0.3)\n- [ ] Test: low-confidence proposal (0.3) yields high risk (\u003e0.5)\n- [ ] Test: long branch in exposition yields elevated pacing risk\n- [ ] Determinism: 10 calls with same input produce identical score\n\n## Related Feature\nge-hch.5.15.3 (Risk Scorer)","status":"closed","priority":1,"issue_type":"task","assignee":"@Patch","created_at":"2026-01-16T15:03:35.389561441-08:00","created_by":"rgardler","updated_at":"2026-01-17T19:01:07.774489902-08:00","closed_at":"2026-01-17T19:01:07.774489902-08:00","close_reason":"Completed","dependencies":[{"issue_id":"ge-hch.5.15.15","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:35.390300568-08:00","created_by":"rgardler"}],"comments":[{"id":205,"issue_id":"ge-hch.5.15.15","author":"rgardler","text":"Added risk scorer test coverage: pacing risk elevated for long exposition, 10-run determinism, confidence-based thresholds align with acceptance; targeted test run via 'npm test --silent -- tests/unit/director.test.js' (fails globally due to start-server-and-test argument requirement, but direct jest run passes).","created_at":"2026-01-18T02:56:32Z"},{"id":206,"issue_id":"ge-hch.5.15.15","author":"rgardler","text":"Opened PR https://github.com/TheWizardsCode/GEngine/pull/166 (ge-hch.5.15.15: add risk scorer tests). Branch feature/ge-hch.5.15.15-risk-scorer-tests pushed. Tests: npm test --silent -- tests/unit/director.test.js (director suite passes; overall script exits with start-server-and-test arg error); npx jest tests/unit/director.test.js --runInBand (pass).","created_at":"2026-01-18T02:57:38Z"}]}
{"id":"ge-hch.5.15.16","title":"Implement: Embedding Service","description":"Create web/demo/js/embedding-service.js with transformers.js.\n\n## Acceptance Criteria\n- [ ] Loads Xenova/all-MiniLM-L6-v2 model via transformers.js\n- [ ] WebWorker wrapper for non-blocking inference\n- [ ] embed(text) returns embedding vector\n- [ ] similarity(vec1, vec2) returns cosine similarity\n- [ ] Lazy loading on first use\n- [ ] Graceful fallback if model fails\n\n## Related Feature\nge-hch.5.15.4 (Embedding Service)","status":"closed","priority":2,"issue_type":"task","assignee":"@Patch","created_at":"2026-01-16T15:03:41.761163209-08:00","created_by":"rgardler","updated_at":"2026-01-17T20:15:52.375357302-08:00","closed_at":"2026-01-17T20:15:52.375357302-08:00","close_reason":"Completed via PR #170","external_ref":"gh-170","labels":["Status: PR Created"],"dependencies":[{"issue_id":"ge-hch.5.15.16","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:41.761957697-08:00","created_by":"rgardler"}],"comments":[{"id":212,"issue_id":"ge-hch.5.15.16","author":"rgardler","text":"Opened PR https://github.com/TheWizardsCode/GEngine/pull/170 for embedding service. Added web/demo/js/embedding-service.js: lazy loads Xenova/all-MiniLM-L6-v2 via transformers.js inside a Web Worker; provides embed(text)-\u003eembedding (null on failure) and similarity(vecA, vecB). Graceful fallback when workers/transformers unavailable. Tests run: npx jest tests/unit/director.test.js --runInBand (pass).","created_at":"2026-01-18T03:31:14Z"},{"id":213,"issue_id":"ge-hch.5.15.16","author":"rgardler","text":"PR #170 merged. Deleted branch feature/ge-hch.5.15.16-embedding locally and remotely. Closing bead as Completed via PR #170.","created_at":"2026-01-18T04:15:54Z"}]}
{"id":"ge-hch.5.15.17","title":"Tests: Embedding Service","description":"Unit tests for embedding service.\n\n## Acceptance Criteria\n- [ ] Test: similarity(happy, joyful) \u003e 0.7\n- [ ] Test: similarity(happy, database) \u003c 0.4\n- [ ] Test: embed(null) returns null gracefully\n- [ ] Performance: first embed \u003c 3s, subsequent \u003c 100ms\n\n## Related Feature\nge-hch.5.15.4 (Embedding Service)","status":"open","priority":2,"issue_type":"task","assignee":"Probe","created_at":"2026-01-16T15:03:41.806727691-08:00","created_by":"rgardler","updated_at":"2026-01-16T15:03:41.806727691-08:00","dependencies":[{"issue_id":"ge-hch.5.15.17","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:41.807448395-08:00","created_by":"rgardler"}]}
{"id":"ge-hch.5.15.17","title":"Tests: Embedding Service","description":"Unit tests for embedding service.\n\n## Acceptance Criteria\n- [ ] Test: similarity(happy, joyful) \u003e 0.7\n- [ ] Test: similarity(happy, database) \u003c 0.4\n- [ ] Test: embed(null) returns null gracefully\n- [ ] Performance: first embed \u003c 3s, subsequent \u003c 100ms\n\n## Related Feature\nge-hch.5.15.4 (Embedding Service)","status":"in_progress","priority":2,"issue_type":"task","assignee":"@Patch","created_at":"2026-01-16T15:03:41.806727691-08:00","created_by":"rgardler","updated_at":"2026-01-17T20:19:37.794552928-08:00","external_ref":"gh-171","labels":["Status: PR Created"],"dependencies":[{"issue_id":"ge-hch.5.15.17","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:41.807448395-08:00","created_by":"rgardler"}],"comments":[{"id":214,"issue_id":"ge-hch.5.15.17","author":"rgardler","text":"PR https://github.com/TheWizardsCode/GEngine/pull/171 opened. Added deterministic unit tests for similarity thresholds (happy/joyful \u003e 0.7, happy/database \u003c 0.4), embed(null) fallback, and mocked worker plumbing for embed(). Optional gated integration test (INTEGRATION_EMBEDDING=1) included for real model check. Tests run: npx jest tests/unit/embedding.service.similarity.test.js tests/unit/embedding.service.embed.test.js --runInBand; npx jest tests/unit/director.test.js --runInBand.","created_at":"2026-01-18T04:19:41Z"}]}
{"id":"ge-hch.5.15.18","title":"Implement: Player Preference Tracker","description":"Create web/demo/js/player-preference.js for tracking preferences.\n\n## Acceptance Criteria\n- [ ] Records { branchType, accepted, timestamp } events\n- [ ] Computes preference score per branch type (0.0-1.0)\n- [ ] Persists in localStorage key ge-hch.ai-preferences\n- [ ] Cold-start returns 0.5 for all types\n- [ ] getPreference(branchType) and recordOutcome(branchType, accepted) APIs\n\n## Related Feature\nge-hch.5.15.5 (Player Preference Tracker)","status":"open","priority":2,"issue_type":"task","assignee":"Patch","created_at":"2026-01-16T15:03:51.748963075-08:00","created_by":"rgardler","updated_at":"2026-01-16T15:03:51.748963075-08:00","dependencies":[{"issue_id":"ge-hch.5.15.18","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:51.750476216-08:00","created_by":"rgardler"}]}
{"id":"ge-hch.5.15.19","title":"Tests: Player Preference Tracker","description":"Unit tests for player preference tracking.\n\n## Acceptance Criteria\n- [ ] Test: 3 accepts + 1 reject of dialogue yields preference \u003e 0.6\n- [ ] Test: 0 history yields preference = 0.5\n- [ ] Test: 100+ events still performant (\u003c10ms)\n- [ ] Test: localStorage persistence works\n\n## Related Feature\nge-hch.5.15.5 (Player Preference Tracker)","status":"open","priority":2,"issue_type":"task","assignee":"Probe","created_at":"2026-01-16T15:03:51.807524607-08:00","created_by":"rgardler","updated_at":"2026-01-16T15:03:51.807524607-08:00","dependencies":[{"issue_id":"ge-hch.5.15.19","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:03:51.808421437-08:00","created_by":"rgardler"}]}
{"id":"ge-hch.5.15.2","title":"Return-Path Feasibility Checker","description":"Validate that the AI's proposed return knot exists in the story to prevent dead-ends.\n\n## Player Experience Change\nPlayers will never be stranded in an AI branch with no way back. If the AI proposes a non-existent return path, the choice is silently rejected.\n\n## Acceptance Criteria\n- [ ] Returns `{ feasible: boolean, reason: string, confidence: number }`\n- [ ] `feasible=true` if `return_path` knot exists in story (confidence=0.9)\n- [ ] `feasible=false` if knot does not exist (confidence=0.0, reason='Return path knot does not exist')\n- [ ] Completes in \u003c50ms\n- [ ] Unit test: `return_path: 'campfire'` passes (knot exists in demo.ink)\n- [ ] Unit test: `return_path: 'nonexistent_knot_xyz'` fails\n- [ ] Integration test: Director rejects proposal with invalid return_path\n\n## Minimal Implementation\n- Create `checkReturnPath(returnPath, story)` function\n- Extract knot names from `story.mainContentContainer._namedContent`\n- Simple existence check\n\n## Dependencies\n- ge-hch.5.15.1 (Decision Flow Engine)\n\n## Deliverables\n- Return-path checker in director.js\n- Unit tests with valid/invalid return paths","status":"closed","priority":1,"issue_type":"feature","created_at":"2026-01-16T15:01:40.467783504-08:00","created_by":"rgardler","updated_at":"2026-01-17T10:51:48.6478971-08:00","closed_at":"2026-01-17T10:51:48.6478971-08:00","close_reason":"Return-path checker implemented, tested and integrated into Director","dependencies":[{"issue_id":"ge-hch.5.15.2","depends_on_id":"ge-hch.5.15","type":"parent-child","created_at":"2026-01-16T15:01:40.469157452-08:00","created_by":"rgardler"},{"issue_id":"ge-hch.5.15.2","depends_on_id":"ge-hch.5.15.1","type":"blocks","created_at":"2026-01-16T15:04:32.206416228-08:00","created_by":"rgardler"}]}
Expand Down
Loading