Skip to content

AI Observer Foundation Review & Polish (M9.1)#20

Merged
SorraTheOrc merged 5 commits into
mainfrom
copilot/vivid-chinchilla
Nov 30, 2025
Merged

AI Observer Foundation Review & Polish (M9.1)#20
SorraTheOrc merged 5 commits into
mainfrom
copilot/vivid-chinchilla

Conversation

Copy link
Copy Markdown

Copilot AI commented Nov 30, 2025

Closes #19. Reviews and polishes the AI Observer implementation to meet M9.1 acceptance criteria for both local SimEngine and remote SimServiceClient modes.

Bug Fix

  • Fixed _get_state() in observer.py to unwrap the data field from service responses when using SimServiceClient

Integration Tests

  • Added 4 new tests for SimServiceClient mode covering tick observation, trend detection, commentary generation, and JSON output
  • Refactored to use pytest fixture for proper client resource cleanup

Documentation

  • Enhanced README with explicit local/remote mode examples:
# Remote SimServiceClient mode
from gengine.echoes.client import SimServiceClient
from gengine.ai_player import Observer, ObserverConfig

with SimServiceClient("http://localhost:8000") as client:
    observer = Observer(client=client, config=ObserverConfig(tick_budget=50))
    report = observer.observe()
    print(report.stability_trend.to_dict())

Tracker

  • Updated .pm/tracker.md task 9.1.1 status to completed
Original prompt

"Issue #19 AI Observer review and polish" to gamedev agent

Created from Copilot CLI via the copilot delegate command.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 30, 2025 23:20
Co-authored-by: SorraTheOrc <250240+SorraTheOrc@users.noreply.github.com>
Co-authored-by: SorraTheOrc <250240+SorraTheOrc@users.noreply.github.com>
Copilot AI changed the title [WIP] Polish AI Observer based on review feedback AI Observer Foundation Review & Polish (M9.1) Nov 30, 2025
Copilot AI requested a review from SorraTheOrc November 30, 2025 23:26
@SorraTheOrc SorraTheOrc merged commit 4f5d5cd into main Nov 30, 2025
@SorraTheOrc SorraTheOrc deleted the copilot/vivid-chinchilla branch December 1, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9.1.1 — AI Observer Foundation Review & Polish (M9.1)

2 participants