Expand SimEngine API and error-path tests (#44)#47
Merged
Conversation
Add 26 new tests (8 to 34 total) covering: - Initialization validation - Query view with all views and invalid names - Director feed API - Explanations API (timeline, metrics, factions, agents, districts, why) - Progression API (summary, success chance, agent modifiers, roster) - Error paths (uninitialized engine, tick limits, invalid views) Co-authored-by: SorraTheOrc <250240+SorraTheOrc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Expand SimEngine API and error-path tests
Expand SimEngine API and error-path tests (#44)
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive test coverage for all public SimEngine APIs and error handling paths.
Tests Added (26 new, 8→34 total)
Initialization & Views
initialize_statevalidation (missing args, state before init)query_viewfor all types (summary, snapshot, district, post-mortem)APIs
director_feedstructure and population after ticksquery_timeline,explain_metric,explain_faction,explain_agent,explain_district,whyprogression_summary,calculate_success_chance(with/without agent/faction),agent_roster_summaryError Paths
EngineNotInitializedErroron premature state accessValueErroron tick limit exceededValueErroron unknown viewsProgression State
Original prompt
Created from Copilot CLI via the copilot delegate command.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.