[IMP] #9787 Update depth for new branches#39
[IMP] #9787 Update depth for new branches#39gfcapalbo merged 1 commit intomaster-depth-calculationfrom
Conversation
Also do not break on brand new remotes.
| return int(mindepth) | ||
| except Exception: | ||
| # Should log/print some error here. | ||
| return 1024 |
There was a problem hiding this comment.
@NL66278 why return 1024, if no mindepth was found this is an error that must be stopping or at least skipping.
THis would mean that the two branches have no history in common.
It used to return nothing on non-existing branches....now with your fetch command it should not happen anymore.
shouldn't we just : return error , log it and skip?
If error occurs we will have a reason to look at logs and fix the case this might happen.
I will merge now, but change this detail on future commit.
There was a problem hiding this comment.
The more likely cause is the repo not having been fetched before. This will allow the build to continue. Then on a new iteration, the repo will have been fetched and the depth will be adjusted to what is really needed.
2 participants
Also do not break on brand new remotes.