Skip to content

Feature/issue 32/home route clarity#33

Merged
urjitc merged 5 commits intomainfrom
feature/issue-32/home-route-clarity
Jan 17, 2026
Merged

Feature/issue 32/home route clarity#33
urjitc merged 5 commits intomainfrom
feature/issue-32/home-route-clarity

Conversation

@urjitc
Copy link
Member

@urjitc urjitc commented Jan 17, 2026

Fixes #32


Important

Change default redirect and navigation from /dashboard to /home across authentication, onboarding, and shared workspace components.

  • Behavior:
    • Change default redirect from /dashboard to /home in AuthPage, GuestSetupPage, OnboardingPage, and SharePage.
    • Update proxy.ts to redirect authenticated users from root to /home.
  • Components:
    • Add HomePage component in home/page.tsx with SEO and DashboardShell.
    • Modify WorkspacePage in dashboard/[slug]/page.tsx to use DashboardShell.
  • Misc:
    • Rename DashboardPage to DashboardShell in dashboard/page.tsx and export it.
    • Update links in Navbar and WorkspaceSidebar to point to /home instead of /dashboard.
    • Adjust comments and documentation to reflect the new default route.

This description was created by Ellipsis for a663210. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • New Features

    • New Home page added as the central hub.
    • Dashboard UI refactored into a reusable shell for improved modularity.
  • Updates

    • App-wide navigation now treats Home as the primary destination (replaces Dashboard in redirects and links).
    • Onboarding, sign-in/sign-up, guest setup, share flows, modals, and workspace deletion now redirect to Home where applicable.
    • Navigation items updated to point to Home.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
thinkexv2 Ready Ready Preview, Comment Jan 17, 2026 7:27pm

@coderabbitai
Copy link

coderabbitai bot commented Jan 17, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Redirects and landing route behavior were changed: the app introduces a new /home landing page using extracted dashboard components, many hardcoded /dashboard targets were replaced with /home, and the auth default redirect was adjusted to /onboarding.

Changes

Cohort / File(s) Summary
Auth redirect update
src/app/auth/[path]/page.tsx
Default redirect fallback changed from /dashboard to /onboarding.
Dashboard shell & routes
src/app/dashboard/page.tsx, src/app/dashboard/[slug]/page.tsx
Extracted DashboardShell as a named export; default Page now redirects to /home. src/app/dashboard/[slug]/page.tsx became an async WorkspacePage that renders SEO and DashboardShell.
New home route
src/app/home/page.tsx
Added HomePage default export that renders SEO metadata and DashboardShell as the new primary landing page.
Post-flow redirect updates
src/app/guest-setup/page.tsx, src/app/onboarding/page.tsx, src/app/share/[id]/page.tsx
Replaced post-auth/post-onboarding/post-import redirects from /dashboard to /home. Onboarding now also treats /home as an excluded path for redirect_url handling.
Navigation components
src/components/landing/Navbar.tsx, src/components/workspace-canvas/WorkspaceSidebar.tsx, src/components/workspace/SharedWorkspaceModal.tsx
Updated hardcoded navigation targets from /dashboard to /home (desktop CTA, mobile menu, sidebar home link, modal close behavior).
Context & middleware
src/contexts/WorkspaceContext.tsx, src/proxy.ts
Workspace deletion fallback and middleware root/unauthenticated redirect fallbacks updated from /dashboard to /home. Comments updated accordingly.

Sequence Diagram(s)

(Skipped — changes are primarily redirects, exports, and route composition without a new multi-component sequential flow warranting a diagram.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I hopped from Dashboard to a cozier home,
SEO in my paws, a shell to call my own,
Redirects re-routed, links all set right,
A tidy front door, and the path feels light.

🚥 Pre-merge checks | ✅ 3 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 43.75% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Out of Scope Changes check ❓ Inconclusive The PR introduces a new HomePage component with SEO configuration and exports DashboardShell for reuse, which are necessary supporting changes for the route migration but extend beyond the basic redirect replacement stated in issue #32. Clarify whether the HomePage component, SEO additions, and component exports are required scope or enhancement beyond the core /dashboard → /home migration objective.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Feature/issue 32/home route clarity' directly references the linked issue (#32) and accurately summarizes the main change: replacing the /dashboard route with /home for improved clarity.
Linked Issues check ✅ Passed All code changes align with issue #32 requirements: /dashboard routes replaced with /home across authentication, onboarding, shared workspaces, proxy redirects, and navigation components [#32].

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@urjitc urjitc self-assigned this Jan 17, 2026
@urjitc urjitc added the enhancement New feature or request label Jan 17, 2026
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a663210 in 1 minute and 14 seconds. Click for details.
  • Reviewed 291 lines of code in 12 files
  • Skipped 0 files when reviewing.
  • Skipped posting 9 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/app/auth/[path]/page.tsx:21
  • Draft comment:
    Ensure the default redirect '/onboarding' is intentional for new users.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. src/app/dashboard/page.tsx:503
  • Draft comment:
    The default Dashboard page now performs a client-side redirect to '/home'. Confirm that this behavior meets your navigation requirements.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm their navigation requirements, which violates the rule against asking for confirmation of intentions. It does not provide a specific code suggestion or point out a potential issue that needs addressing.
3. src/app/guest-setup/page.tsx:55
  • Draft comment:
    Verify that redirecting to /dashboard/[slug] when data.slug exists is intended, given that the base '/dashboard' now redirects to '/home'.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to verify their intention regarding a redirect behavior. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.
4. src/app/onboarding/page.tsx:71
  • Draft comment:
    Redirect for existing users has been updated to '/home'—this aligns with the new navigation design.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. src/app/share/[id]/page.tsx:171
  • Draft comment:
    The redirect now points to '/home' when the modal is closed. Ensure that the flow remains smooth for users coming from shared links.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
6. src/components/landing/Navbar.tsx:141
  • Draft comment:
    The Dashboard link has been updated to point to '/home', ensuring consistency with the new route.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. src/components/workspace-canvas/WorkspaceSidebar.tsx:198
  • Draft comment:
    The home icon link has been updated to '/home', matching the new route structure.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
8. src/contexts/WorkspaceContext.tsx:131
  • Draft comment:
    Empty workspace redirection now goes to '/home' instead of '/dashboard', which appears consistent with the new flow.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
9. src/proxy.ts:22
  • Draft comment:
    Proxy-based redirects have been updated to use '/home' for authenticated users. Verify that this covers all needed scenarios.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_sXDbPhvymjHfjlzF

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 17, 2026

Greptile Summary

Refactors routing architecture to introduce /home as the primary route for users without an active workspace, replacing /dashboard. The /dashboard route now redirects to /home, while /dashboard/[slug] continues to serve workspaces with active slugs.

Major changes:

  • Created new /home page that renders DashboardShell with appropriate SEO
  • Refactored src/app/dashboard/page.tsx to export DashboardShell, DashboardPage, SidebarCoordinator, and AnonymousSessionHandler for reuse
  • Updated /dashboard default export to redirect to /home using router.replace()
  • Updated all navigation links, redirects, and fallback routes across the application to use /home instead of /dashboard
  • Updated middleware redirects in proxy.ts to point authenticated users to /home
  • Added /home to the redirect filter logic in onboarding flow

Issue found:

  • Missing "use client" directive in the new default export of src/app/dashboard/page.tsx (uses useRouter and useEffect hooks)

Confidence Score: 4/5

  • Safe to merge after fixing the missing "use client" directive
  • The refactoring is well-executed with consistent updates across all redirect points and navigation links. The architecture change is clean, introducing /home as the workspace selection page while maintaining /dashboard/[slug] for active workspaces. However, there's a critical syntax error: the new default export in src/app/dashboard/page.tsx uses React hooks (useRouter, useEffect) without the required "use client" directive, which will cause a runtime error in Next.js.
  • Fix the "use client" directive in src/app/dashboard/page.tsx before merging

Important Files Changed

Filename Overview
src/app/dashboard/page.tsx Refactored to redirect /dashboard to /home, extracted DashboardShell component for reuse
src/app/home/page.tsx New home page created, renders DashboardShell with appropriate SEO metadata
src/proxy.ts Updated redirects from /dashboard to /home, updated comments accordingly

Sequence Diagram

sequenceDiagram
    participant User
    participant Middleware as Middleware (proxy.ts)
    participant Dashboard as /dashboard
    participant Home as /home
    participant DashboardSlug as /dashboard/[slug]
    participant Auth as Auth Pages
    participant Onboarding
    participant GuestSetup as /guest-setup
    
    Note over User,GuestSetup: Authenticated User Flow
    User->>Middleware: Visit /
    Middleware->>Home: Redirect to /home (with session)
    
    User->>Middleware: Visit /sign-in
    Middleware->>Home: Redirect to /home (with session)
    
    User->>Dashboard: Visit /dashboard
    Dashboard->>Home: Redirect to /home (router.replace)
    
    User->>Home: Visit /home
    Home->>DashboardSlug: Render DashboardShell (no workspace)
    
    User->>DashboardSlug: Visit /dashboard/workspace-slug
    DashboardSlug->>DashboardSlug: Render DashboardShell (active workspace)
    
    Note over User,GuestSetup: Onboarding Flow
    User->>Auth: Sign up
    Auth->>Onboarding: Redirect to /onboarding
    Onboarding->>Onboarding: Create workspace
    alt New user with demo workspace
        Onboarding->>DashboardSlug: Redirect to /dashboard/demo-slug
    else Existing user
        Onboarding->>Home: Redirect to /home
    end
    
    Note over User,GuestSetup: Guest/Anonymous Flow
    User->>GuestSetup: Visit /guest-setup
    GuestSetup->>GuestSetup: Create anonymous session
    GuestSetup->>GuestSetup: Create welcome workspace
    alt Workspace created
        GuestSetup->>DashboardSlug: Redirect to /dashboard/slug
    else No workspace
        GuestSetup->>Home: Redirect to /home
    end
    
    Note over User,GuestSetup: Workspace Deletion Flow
    User->>DashboardSlug: Delete current workspace
    alt Other workspaces exist
        DashboardSlug->>DashboardSlug: Switch to first workspace
    else No workspaces left
        DashboardSlug->>Home: Redirect to /home
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/app/dashboard/[slug]/page.tsx">

<violation number="1" location="src/app/dashboard/[slug]/page.tsx:15">
P3: The SEO metadata uses a static `/dashboard` URL/canonical on a dynamic `/dashboard/[slug]` route, so every workspace page reports the same canonical URL. Use the route slug to build the URL/canonical (or explicitly mark it noindex) so metadata matches the actual page.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

cubic-dev-ai[bot] and others added 2 commits January 17, 2026 19:21
@sonarqubecloud
Copy link

@urjitc urjitc moved this from Backlog to In progress in Dev Board Jan 17, 2026
@urjitc urjitc moved this from In progress to In review in Dev Board Jan 17, 2026
@urjitc urjitc merged commit b9535b6 into main Jan 17, 2026
5 checks passed
@urjitc urjitc deleted the feature/issue-32/home-route-clarity branch January 17, 2026 19:27
@github-project-automation github-project-automation bot moved this from In review to Done in Dev Board Jan 17, 2026
@coderabbitai coderabbitai bot mentioned this pull request Jan 18, 2026
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

/dashboard route with no workspace selected should just be /home for clarity and maintainabillity

1 participant