fix(protocol): JSON Schema type union for remote tool schemas (#198)#199
Merged
jesse-engineer merged 4 commits intoApr 16, 2026
Conversation
Property.Type is now PropertyType ([]DataType) with custom JSON marshal/unmarshal so remote tool schemas like type: ["string","number"] decode correctly (e.g. MCP ListTools). Validation treats multiple types as a union. Adds regression tests for unmarshaling and union validation. Fixes ThinkInAIXYZ#198 Made-with: Cursor
…schema-union-type Resolve test conflicts: PropertyType + []any enums; fix middleware example Property literals. Made-with: Cursor
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…SON decode Cover union type arrays on nested properties and schemas containing $ref so ListToolsResult unmarshaling stays compatible with remote servers. Made-with: Cursor
Replace slices.Equal with a small equalPropertyType helper; std slices requires Go 1.21+. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remote MCP servers may emit JSON Schema where the
typekeyword is an array (e.g.["string","number"]). The previousPropertymodel used a singleDataType, soListToolsresponses failed to unmarshal with:cannot unmarshal array into ... type protocol.DataTypeChanges
PropertyType([]DataType) withMarshalJSON/UnmarshalJSONaccepting either a string or an array of strings.validateso multiple declared types are treated as a union (OR).TestInputSchema_JSON_unionType/Test_validate_unionType.Related
Fixes #198
Made with Cursor