Skip to content

chore: update to go-licenses/v2#271

Merged
iamjoemccormick merged 1 commit intomainfrom
iamjoe/chore/update-go-license
Nov 3, 2025
Merged

chore: update to go-licenses/v2#271
iamjoemccormick merged 1 commit intomainfrom
iamjoe/chore/update-go-license

Conversation

@iamjoemccormick
Copy link
Member

@iamjoemccormick iamjoemccormick commented Nov 3, 2025

What does this PR do / why do we need it?

Required for all PRs.

While we only used it in CI checks, when we switched to running/managing go-license using go tool in #270 this added its dependencies to our go.mod file which flagged the current version as having multiple security vulnerabilities. I upgraded it to the latest version which also notably added support for instances where there are multiple licenses in one LICENSE file.

Related Issue(s)

Required when applicable.

Where should the reviewer(s) start reviewing this?

Only required for larger PRs when this may not be immediately obvious.

Are there any specific topics we should discuss before merging?

Not required.

What are the next steps after this PR?

Not required.

Checklist before merging:

Required for all PRs.

When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:

  • Documentation:
    • Does developer documentation (code comments, readme, etc.) need to be added or updated?
    • Does the user documentation need to be expanded or updated for this change?
  • Testing:
    • Does this functionality require changing or adding new unit tests?
    • Does this functionality require changing or adding new integration tests?
  • Git Hygiene:

For more details refer to the Go coding standards and the pull request process.

This notably adds support for when there are multiple licenses in one LICENSE file.
@iamjoemccormick iamjoemccormick self-assigned this Nov 3, 2025
@iamjoemccormick iamjoemccormick requested a review from a team as a code owner November 3, 2025 20:29
@iamjoemccormick iamjoemccormick added the ci/cd Additions or improvements to CI/CD workflows. label Nov 3, 2025
Copy link
Contributor

@swartzn swartzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamjoemccormick iamjoemccormick merged commit bccc090 into main Nov 3, 2025
6 checks passed
@iamjoemccormick iamjoemccormick deleted the iamjoe/chore/update-go-license branch November 3, 2025 20:36
iamjoemccormick added a commit that referenced this pull request Nov 5, 2025
This notably adds support for when there are multiple licenses in one LICENSE file.

(cherry picked from commit bccc090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Additions or improvements to CI/CD workflows.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants