Skip to content

fix(ctl): ignore post checks for completion and version modes#297

Merged
iamjoemccormick merged 1 commit intomainfrom
iamjoe/fix/ctl-completion-skip-checks
Feb 17, 2026
Merged

fix(ctl): ignore post checks for completion and version modes#297
iamjoemccormick merged 1 commit intomainfrom
iamjoe/fix/ctl-completion-skip-checks

Conversation

@iamjoemccormick
Copy link
Member

@iamjoemccormick iamjoemccormick commented Feb 17, 2026

What does this PR do / why do we need it?

Required for all PRs.

Ignore post checks for completion and version modes. In particular having these checks on the completion mode meant TLS had to be configured for package builds. Also:

  • Clarify related errors to simplify troubleshooting.
  • Fixes a bug where the top level help command required root access.

Related Issue(s)

Required when applicable.

Where should the reviewer(s) start reviewing this?

Only required for larger PRs when this may not be immediately obvious.

Are there any specific topics we should discuss before merging?

Not required.

What are the next steps after this PR?

Not required.

Checklist before merging:

Required for all PRs.

When creating a PR these are items to keep in mind that cannot be checked by GitHub actions:

  • Documentation:
    • Does developer documentation (code comments, readme, etc.) need to be added or updated?
    • Does the user documentation need to be expanded or updated for this change?
  • Testing:
    • Does this functionality require changing or adding new unit tests?
    • Does this functionality require changing or adding new integration tests?
  • Git Hygiene:

For more details refer to the Go coding standards and the pull request process.

@iamjoemccormick iamjoemccormick self-assigned this Feb 17, 2026
@iamjoemccormick iamjoemccormick requested a review from a team as a code owner February 17, 2026 14:11
@iamjoemccormick iamjoemccormick added the bug Something isn't working label Feb 17, 2026
@iamjoemccormick iamjoemccormick force-pushed the iamjoe/fix/ctl-completion-skip-checks branch from 8eb570b to a439052 Compare February 17, 2026 15:50
- Clarify related errors to simplify troubleshooting.
- Fixes a bug where the top level help command required root access.
@iamjoemccormick iamjoemccormick force-pushed the iamjoe/fix/ctl-completion-skip-checks branch from a439052 to eb4ed1f Compare February 17, 2026 17:16
Copy link
Contributor

@swartzn swartzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamjoemccormick iamjoemccormick merged commit 63e8191 into main Feb 17, 2026
6 checks passed
@iamjoemccormick iamjoemccormick deleted the iamjoe/fix/ctl-completion-skip-checks branch February 17, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants