You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be helpful to clarify what is the point of this repo? Is it for documenting high level concepts or for building a design system in code?
I like the concept (state) => ({ styles, view }), as it makes views also composable, meaning we can could technically build a functional design system without any UI and call that 1.0.0. This might be a good way to start the system, but also useful for flexibility of a styled system in the future.
General readability suggestions:
Include Thinkmill's logo and branding at the top of the README
Terminology items should be hash links to their navigable heading
Where you reference other content such as "State management", why don't you simplify this repo by linking out to that instead of duplicating information to here? State management is not strictly a design system concern. Leave this documentation for design system concerns.
I can see this is early days, but you seem to be missing whole sections like Testing, Types, Type Concepts, Component Inheritance, How to add a component.
It would be helpful to clarify what is the point of this repo? Is it for documenting high level concepts or for building a design system in code?
I like the concept
(state) => ({ styles, view }), as it makes views also composable, meaning we can could technically build a functional design system without any UI and call that 1.0.0. This might be a good way to start the system, but also useful for flexibility of a styled system in the future.General readability suggestions: