Feature: Replace cross-env with pnpm shellEmulator#1489
Merged
emmatown merged 2 commits intoThinkmill:mainfrom Mar 23, 2026
Merged
Conversation
|
emmatown
approved these changes
Mar 23, 2026
emmatown
force-pushed
the
feature/replace-cross-env-with-pnpm-shell-emulator
branch
from
7574123 to
ca447ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the development environment (and reduces dependencies to install for CI testing), since we already use
pnpmwhich has this feature built-in.I also documented the test case in
Toast.test.tsxthat fails when run withpnpm test-strict. It might be worth looking into if the test case could be written in a different way, but this is out of scope for this change so I opted for a comment instead.