Preserve user-hidden status item defaults#1
Open
hhh2210 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the status item defaults repair logic to avoid removing user-intended “hidden” keys after the initial migration repair, and extends tests to cover the repeated-run behavior.
Changes:
- Adjusted
repairHiddenVisibilityDefaultsIfNeededto respectdidRepairKeywhen deciding whether to delete legacy autosave keys. - Renamed an existing test and added a new test to verify repeated cleanup behavior without overriding later user hides.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tests/CodexBarTests/StatusItemControllerSplitLifecycleTests.swift | Renames a repair-related test and adds coverage for repeat-run behavior with didRepairKey set. |
| Sources/CodexBar/MenuBarStatusItemDefaultsRepair.swift | Gates legacy autosave cleanup based on didRepairKey while continuing default-item cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+25
to
30
| static func shouldRepair(key: String, value: Any?, didRepair: Bool = false) -> Bool { | ||
| guard key.hasPrefix(self.visibilityPrefix), self.isFalse(value) else { return false } | ||
| let itemName = String(key.dropFirst(self.visibilityPrefix.count)) | ||
| return itemName.hasPrefix(self.legacyAutosavePrefix) || self.isDefaultStatusItemName(itemName) | ||
| if self.isDefaultStatusItemName(itemName) { return true } | ||
| return !didRepair && itemName.hasPrefix(self.legacyAutosavePrefix) | ||
| } |
| @Test | ||
| func `status item defaults repair removes stale hidden Control Center keys repeatedly`() throws { | ||
| func `status item defaults repair removes stale hidden Control Center keys during migration`() throws { | ||
| let suite = "StatusItemControllerSplitLifecycleTests-repair-repeated-\(UUID().uuidString)" |
Comment on lines
366
to
+373
| defaults.set(false, forKey: "NSStatusItem VisibleCC Item-2") | ||
| defaults.set(false, forKey: "NSStatusItem VisibleCC codexbar-codex") | ||
|
|
||
| #expect(MenuBarStatusItemDefaultsRepair.repairHiddenVisibilityDefaultsIfNeeded(defaults: defaults) == [ | ||
| "NSStatusItem VisibleCC Item-2", | ||
| "NSStatusItem VisibleCC codexbar-codex", | ||
| ]) | ||
| #expect(defaults.object(forKey: "NSStatusItem VisibleCC Item-2") == nil) | ||
| #expect(defaults.object(forKey: "NSStatusItem VisibleCC codexbar-codex") == nil) | ||
| #expect(defaults.object(forKey: "NSStatusItem VisibleCC codexbar-codex") != nil) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSStatusItem VisibleCC Item-* = falsekeys.codexbar-* = falsevisibility defaults during the first migration, before the repair marker exists.Follow-up for steipete#1306 and its ClawSweeper P1 blocker.
Tests
make checkswift test --filter StatusItemControllerSplitLifecycleTestsswift testgit diff --checkReview