Skip to content

fix(ui): prepend language text prefixes to mobile selector and fix help/about modal triggers#125

Merged
ThisIs-Developer merged 1 commit into
mainfrom
feature/find-replace-redesign
May 27, 2026
Merged

fix(ui): prepend language text prefixes to mobile selector and fix help/about modal triggers#125
ThisIs-Developer merged 1 commit into
mainfrom
feature/find-replace-redesign

Conversation

@ThisIs-Developer
Copy link
Copy Markdown
Owner

Overview

This PR refines the mobile language selector layout, prepending clean text prefixes to match responsive designs. Additionally, it fixes modal trigger errors by implementing missing helper functions for the Help, About, and Clear Formatting toolbar options.


Key Changes

1. Mobile Language Selector Styling

  • Text Code Prefixes: Prepended lowercase/uppercase text prefixes (us, CN, JP, KR) to mobile menu dropdown options.
  • Selected Indicator: Bounded #mobile-current-lang-label dynamic updates to include text country prefixes during language swaps, matching visual specifications.

2. Help, About, & Clear Formatting Modal Fixes

  • Implemented Actions: Declared openHelpModal(), openAboutModal(), and openClearFormattingModal() within script.js.
  • Toolbar Binding: Linked modal triggers to data-md-action="help", data-md-action="info", and data-md-action="clear-formatting" respectively, restoring functionality for all toolbar and sidebar actions.

3. Packaging & Synchronization

  • Ran compiler scripts (prepare.js) to bundle updated stylesheets and scripts for the NeutralinoJS desktop app.

Copilot AI review requested due to automatic review settings May 27, 2026 12:57
@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview, Comment May 27, 2026 12:58pm

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying markdown-viewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ce63d5
Status:🚫  Build failed.

View logs

@ThisIs-Developer ThisIs-Developer merged commit b142fb6 into main May 27, 2026
5 of 7 checks passed
@ThisIs-Developer ThisIs-Developer deleted the feature/find-replace-redesign branch May 27, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants