feat(live-share): improve first-time session flow#205
Merged
Conversation
Deploying markdownviewer with
|
| Latest commit: |
4497725
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07c24625.markdownviewer.pages.dev |
| Branch Preview URL: | https://codex-live-share-first-time.markdownviewer.pages.dev |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ThisIs-Developer
force-pushed
the
codex/live-share-first-time-flow
branch
from
17993fb to
15a5b18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contribution notes
mainafter syncing the merged Live Share work.Validation
node --check script.jsnode --check functions/live-room/[[room]].jsnode --check functions/api/share/[[id]].jsnode --check workers/live-room-worker.jsnpx wrangler pages functions build functions --outfile .tmp-pages-functions-worker.jsnpx wrangler deploy --config wrangler.live-room.toml --dry-run --outdir .tmp-live-room-worker-buildgit diff --check(only expected CRLF warnings on Windows)index.htmlcontains the first-time flow, invite section, copy button text, and start-session copy.