fix(mobile): polish menu shared states#207
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ThisIs-Developer
force-pushed
the
codex/mobile-menu-live-share-polish
branch
from
3f3178b to
fe7b393
Compare
Deploying markdownviewer with
|
| Latest commit: |
fe7b393
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4c5f0060.markdownviewer.pages.dev |
| Branch Preview URL: | https://codex-mobile-menu-live-share.markdownviewer.pages.dev |
ThisIs-Developer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The global dropdown animation kept hidden dropdown menus as
display: block, so the mobile language dropdown still affected drawer scroll height while invisible. The mobile Live Share action also had no participant container, mobile menu buttons did not have the disabled visual rules used by desktop toolbar buttons, and the Live Share snapshot guard blocked hosts and guests the same way.Validation
wiki/Contributing.mdbefore preparing the changenode --check script.jsgit diff --checkhttp://127.0.0.1:8081and verified the drawer bottom gap dropped to normal padding with the hidden mobile language dropdown no longer contributing scroll height