Improve test suite coverage and validation#128
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_target_text,get_assurance_type,get_variation_type,parse_rebase_dates, andalign_rebase_datescheck_a_data,check_measure_config,check_dataset_is_complete,process_event_data_t, andlengthen_measure_datacheck_for_allowed_values()helper and apply it to validateimprovement_direction,unit,spc_chart_type, andaggregationagainst their allowed sets (withtolowernormalisation)check_a_data()so it fires at bundle entry rather than deep inlengthen_measure_data()check_a_data()error message incorrectly said"check_measure_data:"assert_that(!any(is.na(aggregation)))check incheck_report_config()— covered bycheck_for_allowed_values"description" |> test_that({})pipe style totest_that("description", {})for consistencyTest plan
devtools::test()passes with 0 failures🤖 Generated with Claude Code