Fix plugin does not work when used in Matomo for WordPress #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a report from a user in https://wordpress.org/support/topic/fatal-error-when-trying-to-activate-bot-tracker/ who wanted to use this plugin in Matomo for WordPress. However, it resulted in an error because when `BotTracker.php` is loaded as a WordPress plugin, then `PIWIK_INCLUDE_PATH` might not exist. In the plugins where we used a `functions.php` we instead changed it to load the functions.php a bit later (in this time every time the plugin is being loaded on every request). It will also use the new method `getPluginDirectory` which we added in one of the last releases in Matomo 3.X so this way it supports Matomo's feature to customise the plugins directory.
tsteur
added a commit
to tsteur/BotTracker
that referenced
this pull request
Oct 28, 2021
follow up from Thomas--F#83 The plugin now failed in the API.php where it shouldn't be needed to load the functions.php as it's already done when loading the plugin. Sorry about that and about not including it in the other PR. Should have checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a report from a user in https://wordpress.org/support/topic/fatal-error-when-trying-to-activate-bot-tracker/ who wanted to use this plugin in Matomo for WordPress. However, it resulted in an error because when
BotTracker.phpis loaded as a WordPress plugin, thenPIWIK_INCLUDE_PATHmight not exist. In the plugins where we used afunctions.phpwe instead changed it to load the functions.php a bit later (in this time every time the plugin is being loaded on every request). It will also use the new methodgetPluginDirectorywhich we added in one of the last releases in Matomo 3.X so this way it supports Matomo's feature to customise the plugins directory.