Skip to content
This repository was archived by the owner on Nov 25, 2024. It is now read-only.

Compatibility with newer versions available here! (>= 2021.1)#12

Closed
ThexXTURBOXx wants to merge 42 commits into
ThomasR:masterfrom
ThexXTURBOXx:master
Closed

Compatibility with newer versions available here! (>= 2021.1)#12
ThexXTURBOXx wants to merge 42 commits into
ThomasR:masterfrom
ThexXTURBOXx:master

Conversation

@ThexXTURBOXx
Copy link
Copy Markdown

@ThexXTURBOXx ThexXTURBOXx commented Apr 12, 2021

Please note that I also updated the Copyright years and removed the com.github.ManifestClasspath plugin as it breaks the build on Windows actually (I built the plugin successfully on Windows myself)

Edit: Versions can be found here: https://plugins.jetbrains.com/plugin/18612-diff--patch-file-support

Fixes #10
Fixes #14

@larvanitis
Copy link
Copy Markdown

I just installed intellij-diff-plugin-2.1.7-2021.2-SNAPSHOT.jar to IDEA 2021.1.2 IU-211.7442.40 and so far so good.

@ThexXTURBOXx
Copy link
Copy Markdown
Author

@larvanitis The 2021.2 EAP version worked on 2021.1.2 for you? That's very nice to hear. Maybe, we don't even need the other version after all

@ThexXTURBOXx ThexXTURBOXx changed the title 2021.1 compatibility 2021.2 compatibility Sep 21, 2021
@ThexXTURBOXx ThexXTURBOXx changed the title 2021.3 compatibility 2021.1 - 2022.1 compatibility Jan 27, 2022
@this
Copy link
Copy Markdown

this commented Jan 28, 2022

Latest intellij-diff-plugin-2.1.7-2021.2-SNAPSHOT.jar works with PyCharm 2021.3.1 (Professional Edition).

@denisvmedia
Copy link
Copy Markdown

@ThexXTURBOXx thanks for your efforts. Do you think, it's possible to publish your builds in the official JetBrains marketplace?

@ThexXTURBOXx
Copy link
Copy Markdown
Author

@denisvmedia I also already thought about that since the original author seems to have abandoned this project.
Also, because I am not very familiar with licenses and what they mean, I read up some articles about what I may do with this plugin.
Appearently, I am permitted to distribute my builds as long as I include the original copyright notice and state what I changed in the code.
So, this is exactly what I will do.

I will keep you updated on my progress on uploading the plugin :)

@ThexXTURBOXx
Copy link
Copy Markdown
Author

Uploaded the first version here: https://plugins.jetbrains.com/plugin/18612-diff--patch-file-support

According to JetBrains, the approval process will take two business days. So, I will keep you updated on when the plugin will be available on the Marketplace :)

@ThexXTURBOXx
Copy link
Copy Markdown
Author

The plugin has successfully been approved by JetBrains!
You can now install it from within your IDE directly :)

@VergeDX
Copy link
Copy Markdown

VergeDX commented Jun 16, 2022

Thanks what you've done!

@ThexXTURBOXx ThexXTURBOXx changed the title 2021.1 - 2022.1 compatibility Compatibility with newer versions available here! Sep 23, 2022
@ThexXTURBOXx ThexXTURBOXx changed the title Compatibility with newer versions available here! Compatibility with newer versions available here! (2021.1+) Sep 23, 2022
@ThexXTURBOXx ThexXTURBOXx changed the title Compatibility with newer versions available here! (2021.1+) Compatibility with newer versions available here! (>= 2021.1) Sep 23, 2022
@ThomasR
Copy link
Copy Markdown
Owner

ThomasR commented Nov 25, 2024

Thank you @ThexXTURBOXx for contributing! This is awesome! 🤗

I haven't been active on Github recently, so I will archive my repo and leave the project in your hands.

One final note on the copyright:
Please respect the license terms, specifically section 4. Redistribution

  • The year in my copyright notice should not be changed
  • If you modify a file, you must add a note that you have done so.
  • (Feel free to add your own copyright to any files added by you, as long as it's compatible with Apache-2.0)

@ThexXTURBOXx
Copy link
Copy Markdown
Author

Dear Thomas, thank you very much for your response! :)
Indeed, you are right. I was a newbie when it comes to licensing when I started this fork. I will change these back ASAP!
I will also follow the rest of what is mentioned within the Apache-2.0 license in the future, thank you for the reminder!

@ThomasR ThomasR closed this Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin is incompatible with Idea 2021.2 Plugin is incompatible with PhpStorm 2021.1 EAP

7 participants