Skip to content

Tests#41

Merged
MosDevx merged 36 commits intodevfrom
tests
Jun 27, 2023
Merged

Tests#41
MosDevx merged 36 commits intodevfrom
tests

Conversation

@Thoth1111
Copy link
Owner

@Thoth1111 Thoth1111 commented Jun 27, 2023

In this branch we were able to:
✅ Setup and install all needed dependencies for testing.
✅ Add unit tests for all major components.
✅ Make minor adjustments to login & signup pages.

closes #44

@MosDevx
Copy link
Collaborator

MosDevx commented Jun 27, 2023

Approved 🟢

Hi @Thoth1111

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Details paged looks amazing ✔️
  • No linter errors ✔️
  • Home page responsive in Ipad view ✔️
  • All the functionality is working ✔️
  • Slider overlap has been fixed ✔️
  • Cool at all 😄

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. Some of them were simply missed by the previous reviewer, and addressing them will improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me(@MosDevx ) in your question so I can receive the notification.


As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@MosDevx MosDevx merged commit 0a88b34 into dev Jun 27, 2023
@MosDevx MosDevx linked an issue Jun 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[3pt] Rails Rspec tests

4 participants