Fix transaction building process and update SC invocation methods#11
Merged
itsMarcoSolis merged 1 commit intomainfrom Aug 7, 2024
Merged
Fix transaction building process and update SC invocation methods#11itsMarcoSolis merged 1 commit intomainfrom
itsMarcoSolis merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several issues related to the transaction building process and smart contract invocation methods. The main changes include:
Summary of Changes
AddLiquiditySection:
gasEstimateSCArgsfor accurate gas estimation.destinationparameter in the transfer method to comply with RPC syntax.CreatePairModalContent:
gasEstimateSCArgs.RemoveLiquiditySection:
gasEstimateSCArgsfor smart contract invocation.RemoveLiquidityentrypoint.SwapForm:
strokeWidth,strokeLinecap,strokeLinejoin) for proper rendering.Rationale
These changes enhance the reliability and accuracy of the transaction building process. By using
gasEstimateSCArgs, we ensure that gas estimations are precise, preventing potential transaction failures due to incorrect gas calculations. This change also fixes an issue where the transfer call would be sent without the proper SC_ACTION and SC_ID RPC arguments.Testing
Related Issues