Raise CI coverage gate 75 → 85 (v0.21 E7)#116
Merged
Conversation
Round-4 review item E7: "Threshold bump to 85% (free signal — actual is 87.87%)". Actual aggregate coverage on current `main` measures 88.09% (re-confirmed locally), so the gate is +10pp tighter with ~3pp headroom for day-to-day movement. No source change needed to land; the gate is simply closer to the actual signal. Changes: - ``.github/workflows/ci.yml`` line 48: ``--cov-fail-under=75`` -> ``85`` - ``.github/workflows/release.yml`` line 37: same bump so the release path cannot bypass the tighter floor - ``CHANGELOG.md`` Unreleased entry documenting the bump The bump catches the next time a refactor lands materially less-covered code without corresponding tests. Per-file coverage is not enforced; teams adding lower-covered modules must keep the aggregate >= 85. Verification: - ``python -m pytest --cov-fail-under=85 -q`` exits 0; coverage 88.09% - ``python -m ruff check .`` clean - No source under ``src/`` touched Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Round-4 architecture-review item E7: bump the CI coverage gate from
--cov-fail-under=75to--cov-fail-under=85in both.github/workflows/ci.ymland.github/workflows/release.yml. No source change. Aggregate coverage on currentmainmeasures 88.09% (re-confirmed locally on this branch), so the gate is +10pp tighter with ~3pp headroom for day-to-day movement.The bump is a "free signal" upgrade — the gate moves closer to actual signal without forcing any test additions to land it. It catches the next time a refactor lands materially less-covered code without corresponding tests.
Why now
main) confirmed: actual coverage is now 88.09%; threshold is still 75%.main; time to lock the floor closer to actual.What changed
.github/workflows/ci.yml:48—--cov-fail-under=75→85.github/workflows/release.yml:37— same bump so the release path cannot bypass the tighter floorCHANGELOG.md— Unreleased entry documenting the bumpsrc/changePer-file coverage is not enforced — only the aggregate. Adding a lower-covered module is fine as long as the aggregate stays ≥ 85%.
Verification
python -m pytest --cov=agents_shipgate --cov-report=term-missing --cov-fail-under=85 -qexits 0; coverage 88.09%python -m ruff check .cleansrc/touchedHeadroom note
With the threshold at 85 and actual at 88.09%, a single refactor could theoretically drop coverage by 3pp before the gate fires. If that becomes a recurring problem in practice, the next move is per-file thresholds (or
--cov-fail-under-per-file), not lowering the aggregate.🤖 Generated with Claude Code