Skip to content

Conversation

@Thundernerd
Copy link
Owner

@Thundernerd Thundernerd commented Aug 2, 2022

Proposed changes

Removed the custom line drawing for raw reference drawers to make it look more like Unity natively

Types of changes

Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming)
  • Build related changes (workflow changes)
  • Documentation Update (readme, changelog)
  • Other, please describe: This is a visual style change

What is the current behavior?

Currently when expanding a folded raw reference drawer it will draw a vertical line to highlight the indentation

What is the new behavior?

When expanding a folded raw reference drawer it will no longer draw a vertical line

Checklist

Put an x in the boxes that apply.

  • The code compiles
  • I have tested that this doesn't break existing code (unless it is an explicit breaking change)
  • I have tested that the (new) functionality/fix works as intended
  • I have added necessary documentation (if appropriate)

Further comments

My apologies @marc-antoine-girard as I've reverted your line drawing change. When using I noticed that it feels somewhat out of place. I prefer to have it more neutral and in line with how Unity draws things natively.

@Thundernerd Thundernerd merged commit 11b3949 into main Aug 2, 2022
@Thundernerd Thundernerd deleted the fix/remove_custom_line_drawing branch August 2, 2022 14:13
@Thundernerd
Copy link
Owner Author

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants