Skip to content

Conversation

@tobiascadee
Copy link
Contributor

  • remove incremental stream from conversation_parts

  • add a lot of missing properties

Copilot AI review requested due to automatic review settings October 10, 2025 09:34
@tobiascadee tobiascadee requested a review from a team as a code owner October 10, 2025 09:34
@ghost ghost added the ready for review label Oct 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes incremental streaming from the conversation_parts stream and significantly expands schema coverage across multiple Intercom API entities. The changes add extensive missing properties to better capture the complete data structure from the API responses.

  • Removal of incremental replication key from conversation_parts stream
  • Addition of numerous missing schema properties across conversations, contacts, admins, tags, and articles
  • Comprehensive expansion of nested object schemas with proper type annotations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
tap_intercom/streams.py Removes replication_key from ConversationPartsStream to disable incremental syncing
tap_intercom/schemas.py Adds extensive missing properties to multiple schema definitions including type fields, nested objects, and custom attributes
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tobiascadee tobiascadee merged commit 6e016b8 into main Oct 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants