-
Notifications
You must be signed in to change notification settings - Fork 2
add missing schema properties #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes incremental streaming from the conversation_parts stream and significantly expands schema coverage across multiple Intercom API entities. The changes add extensive missing properties to better capture the complete data structure from the API responses.
- Removal of incremental replication key from
conversation_partsstream - Addition of numerous missing schema properties across conversations, contacts, admins, tags, and articles
- Comprehensive expansion of nested object schemas with proper type annotations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tap_intercom/streams.py | Removes replication_key from ConversationPartsStream to disable incremental syncing |
| tap_intercom/schemas.py | Adds extensive missing properties to multiple schema definitions including type fields, nested objects, and custom attributes |
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
remove incremental stream from
conversation_partsadd a lot of missing properties