-
Notifications
You must be signed in to change notification settings - Fork 0
Update ember-ajax to the latest version 🚀 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
greenkeeper
wants to merge
1
commit into
master
Choose a base branch
from
greenkeeper/ember-ajax-3.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Version 3.1.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 33 commits.
There are 33 commits in total. See the full diff |
Author
Version 3.1.1 just got published.Update to this version instead 🚀 CommitsThe new version differs by 34 commits.
There are 34 commits in total. See the full diff |
Author
Update to this version instead 🚀 CommitsThe new version differs by 5 commits.
See the full diff |
Author
|
Author
|
Author
Update to this version instead 🚀 CommitsThe new version differs by 5 commits.
See the full diff |
Author
|
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0.0 of ember-ajax just got published.
The version 3.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ember-ajax.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
Make it Simple(r)Breaking Changes
Simplifying
normalizeErrorResponseAfter much discussion, the team around
ember-ajaxdecided that it was probably not a great idea to reformat the error payload to match some arbitrary format that we designed. Instead, we should just use the payload that the server returned.If you want to maintain the old behavior, you can include the the
legacy/normalize-error-responsemixin, which has the old version of the method included and will override the new behavior.Replacing
AjaxError.errorswithAjaxError.payloadThe
errorsproperty on anyAjaxErrorsubclass has been deprecated in favor of apayloadproperty for a while now. If you want access to the response from the server, you should now use thepayloadproperty, like so:No longer modify null or undefined server response (#232)
If your server response is interpreted by jQuery#ajax to be
nullorundefined, we will resolve that value, instead of turning it into an empty object.Commits
The new version differs by 49 commits ahead by 49, behind by 7.
2aba19eReleased v3.0.05c6a45aUpgrade dependencies (#283)acd384ffix(package): update ember-cli-babel to version 6.0.0-beta.10 (#277)c70bc9aUpdate to use Babel 6 (#266)528e843Upgradeember-resolverto 4.1.04181656Released v3.0.0-beta.186ab8d0Fix issues with the isString helper723dd66Tighten ESLint config78de692Hide container by default when running testsac023c1Slight cleanup of JSON test helper60cb8demake sure contentType is a string before running a regex match (#250)4e784a2Released v3.0.0-beta.0fe03044Released v2.5.7-beta.0db086b3Released v2.5.71f4ca9dSimplifynormalizeErrorResponse(#265)There are 49 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴