Merged
Conversation
Call emitChange when the "Out-of-hours behaviour" Dropdown changes so updates are propagated. Adds an on:change={emitChange} handler to the Dropdown in SupportHoursForm.svelte to ensure form change events are emitted.
biast12
changed the title
biast12
changed the title
BenHall-1
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a minor update to the
SupportHoursForm.sveltecomponent. The change ensures that any selection change in the "Out-of-hours behaviour" dropdown triggers theemitChangeevent handler, allowing the parent component to react to user input.Type of Change
Testing
Turn on Support Hours on a panel and save the panel
Edit the panel again and select a different Out-of-hours behaviour in the dropdown