feat(RM-24): Add support to set @ here#12
Merged
BenHall-1 merged 8 commits intoTicketsBot-cloud:masterfrom Mar 6, 2025
Merged
Conversation
Contributor
Author
|
This has been tested, you are able to set it in the dashboard (and the database stores it) 2qD0YLcyRw.mp4 |
DanPlayz0
changed the title
DanPlayz0
changed the title
Signed-off-by: Ben <ben@ticketsbot.cloud>
Signed-off-by: Ben <ben@ticketsbot.cloud>
BenHall-1
approved these changes
Mar 6, 2025
Member
BenHall-1
left a comment
BenHall-1
left a comment
There was a problem hiding this comment.
Thanks for the contribution! LGTM 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to mention "@ here" in panel creation, listing, and updating. The changes span backend and frontend files, ensuring that the new mention type is handled correctly across the application.
Backend changes:
app/http/endpoints/api/panel/panelcreate.go: Added support for "@ here" mentions in theCreatePanelfunction and updated thepanelCreateOptionsstruct to includeShouldMentionHere. [1] [2] [3] [4] [5]app/http/endpoints/api/panel/panellist.go: Modified theListPanelsfunction to retrieve and include "@ here" mentions. [1] [2]app/http/endpoints/api/panel/panelupdate.go: Updated theUpdatePanelfunction to handle "@ here" mentions and updated the database accordingly. [1] [2] [3] [4]Frontend changes:
frontend/src/components/manage/PanelCreationForm.svelte: Updated the mention handling to include "@ here" in the mention options and display. [1] [2]