Merged
Conversation
Improves backend logic to enforce min_length and max_length constraints for select input types (3, 5-8), ensuring values are within valid ranges and consistent with options count. Removes redundant frontend logic for auto-setting max_length, delegating all defaulting and validation to the backend for better consistency.
Signed-off-by: Ben <ben@tickets.bot>
* Reset text input fields when switching to text type Adds logic to reset style, min_length, and max_length to default values when changing a field type to text input. This ensures consistent defaults and prevents stale values from other input types. * Remove 'Required' checkbox and adjust config row styles The 'Required' checkbox has been removed from the form input row component. Additionally, some margin and padding styles for config rows and config text have been cleaned up to simplify the layout.
Signed-off-by: Ben <ben@tickets.bot>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.