Skip to content

Fix: Form validation switch and input delete #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHall-1 merged 2 commits into from
Dec 17, 2025
Merged

Fix: Form validation switch and input delete #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c165de0
Reset validation errors on form switch and input delete
biast12 Nov 21, 2025
698f508
Merge branch 'master' into fix-forms
BenHall-1 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions frontend/src/views/Forms.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@

let inputValidationErrors = {};

// Clear validation errors when switching forms
$: if (activeFormId !== null) {
inputValidationErrors = {};
}

// Check if any input has validation errors
$: hasValidationErrors = Object.values(inputValidationErrors).some((hasError) => hasError === true);

Expand Down Expand Up @@ -143,11 +148,18 @@
let form = getForm(formId);

let idx = form.inputs.findIndex((i) => i === input);

// Clean up validation error for the deleted input
delete inputValidationErrors[input.id || idx];

form.inputs.splice(idx, 1);
for (let i = idx; i < form.inputs.length; i++) {
form.inputs[i].position--;
}

// Trigger reactivity for inputValidationErrors
inputValidationErrors = inputValidationErrors;

forms = forms;

if (!input.is_new) {
Expand Down