Skip to content

RM-205: Add placeholder replacement for ticket messages and tags...#65

Merged
BenHall-1 merged 3 commits intoTicketsBot-cloud:masterfrom
biast12:RM-205
Dec 17, 2025
Merged

RM-205: Add placeholder replacement for ticket messages and tags...#65
BenHall-1 merged 3 commits intoTicketsBot-cloud:masterfrom
biast12:RM-205

Conversation

@biast12
Copy link
Copy Markdown
Contributor

@biast12 biast12 commented Nov 27, 2025

Description

RM-205
This PR does 3 thing

  • Add placeholder replacement for ticket messages and tags
  • Disable tag selector button in send message view when no tags are available
  • fix a bug with tags not being able to be updated if they already had an option in it (Normalize empty embed fields to nil in tag creation)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Improvement

Testing

Make a tag both using content and an embed, add some placeholders into it, and try to send it via the dashboard, try to also use the placeholders to send messages via the dashboard too

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Introduces placeholder processing for ticket messages and tags, including embed fields and avatar URLs. Ensures placeholders are replaced with relevant ticket, user, and guild data before sending messages or tags. Also standardizes allowed mentions in outgoing messages.
The 'Select Tag' button is now disabled if there are no tags present, preventing users from opening the tag selector when it would be empty.
Introduces cleanEmbedFields to convert empty strings to nil for optional embed fields in tag creation. This ensures proper validation and handling of optional fields in CustomEmbed objects.
@biast12 biast12 requested a review from a team as a code owner November 27, 2025 21:57
@biast12 biast12 changed the title Rm 205: Add placeholder replacement for ticket messages and tags... RM-205: Add placeholder replacement for ticket messages and tags... Dec 3, 2025
@BenHall-1 BenHall-1 merged commit 16e3d18 into TicketsBot-cloud:master Dec 17, 2025
@biast12 biast12 deleted the RM-205 branch December 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants