Skip to content

Add per panel ticket notification channel support#73

Merged
BenHall-1 merged 2 commits intoTicketsBot-cloud:masterfrom
biast12:RM-48
Dec 30, 2025
Merged

Add per panel ticket notification channel support#73
BenHall-1 merged 2 commits intoTicketsBot-cloud:masterfrom
biast12:RM-48

Conversation

@biast12
Copy link
Copy Markdown
Contributor

@biast12 biast12 commented Dec 20, 2025

Description

RM-48
This PR is the dashboard part of adding per panel ticket notification channel support

Included: TicketsBot-cloud/worker#80
Needs this before accepting: TicketsBot-cloud/database#17

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

Have global thread mode on, in a panel don't turn on per panel thread mode, but select a per panel notification channel, test if that works, then turn per panel thread mode on, change the per panel notification channel to use global and turn global thread mode off (this should error since you need a notification channel), then try the inverted with per panel thread mode (have global thread mode off and try to use the global notification channel, this should error too)

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@BenHall-1
Copy link
Copy Markdown
Member

db changes merged - please update

Copy link
Copy Markdown
Member

@BenHall-1 BenHall-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@BenHall-1 BenHall-1 merged commit 9e84052 into TicketsBot-cloud:master Dec 30, 2025
@biast12 biast12 deleted the RM-48 branch December 30, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants