Skip to content

Add required field to modal comoments#91

Merged
BenHall-1 merged 3 commits intomasterfrom
required-modals
Feb 24, 2026
Merged

Add required field to modal comoments#91
BenHall-1 merged 3 commits intomasterfrom
required-modals

Conversation

@biast12
Copy link
Copy Markdown
Contributor

@biast12 biast12 commented Feb 21, 2026

Expose a 'Required' toggle in the FormInputRow component by adding a Checkbox bound to data.required in two locations (constraint-row and config-row). The checkbox uses an id of the form required-{formId}-{index} for uniqueness, allowing editors to mark fields as mandatory from the UI.
Remove type 21 (radio group) from select/min/max handling in both backend and frontend. Backend: stop treating type 21 as a select for max_length logic and pass nil pointers for MinLength/MaxLength when input.Type == 21 (both update and create paths) so DB won't be updated with min/max for radios. Frontend: remove 21 from typesWithMinMax arrays and hide the min/max UI for type 21. This ensures radio inputs don't receive or display length constraints that don't apply.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Feb 21, 2026

Deploying tickets-v2-dashboard with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4e044d6
Status: ✅  Deploy successful!
Preview URL: https://dd439157.tickets-v2-dashboard.pages.dev
Branch Preview URL: https://required-modals.tickets-v2-dashboard.pages.dev

View logs

@BenHall-1 BenHall-1 merged commit 2459bd6 into master Feb 24, 2026
1 check passed
@BenHall-1 BenHall-1 deleted the required-modals branch February 24, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants