Fix save button validation not reliably reflecting input state#93
Merged
Fix save button validation not reliably reflecting input state#93
Conversation
Validation state from FormInputRow was not reliably reaching the parent Forms.svelte due to Svelte's $: blocks firing during component initialization before on: listeners are guaranteed to be attached. Fixes: - Add onMount dispatch in FormInputRow to guarantee initial validation state is sent after mount - Add hasValidationErrors guard in saveInputs() to block invalid saves regardless of button UI state - Assign stable _key to new inputs so inputValidationErrors uses a consistent key instead of the loop index, which shifts on reorder/delete
ben-sugarcrm
approved these changes
Feb 25, 2026
BenHall-1
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validation state from FormInputRow was not reliably reaching the parent Forms.svelte due to Svelte's $: blocks firing during component initialization before on: listeners are guaranteed to be attached.
Fixes:
Type of Change
Testing
Checklist