Skip to content

RM-250: Fix join ticket does not update for per panel thread mode#130

Merged
BenHall-1 merged 1 commit into
masterfrom
RM-250
Mar 17, 2026
Merged

RM-250: Fix join ticket does not update for per panel thread mode#130
BenHall-1 merged 1 commit into
masterfrom
RM-250

Conversation

@biast12
Copy link
Copy Markdown
Contributor

@biast12 biast12 commented Mar 17, 2026

Description

This pull request fixes the join ticket not updating when a staff joins if using per panel thread mode

Type of Change

  • Bug fix
  • New feature
  • Breaking change

Testing

Only Use per panel thread mode
Join the ticket with another user
The join ticket should then update

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Prefer a panel's TicketNotificationChannel over the guild default when updating thread join/notification messages. Update SwitchPanelCommand and thread members listener to choose the correct notification channel and only attempt message edits when a channel is set. Remove the join-message update logic and unused imports from the join-thread button handler. This avoids nil channel edits and centralizes notification channel selection.
@biast12 biast12 requested a review from a team as a code owner March 17, 2026 18:55
@BenHall-1 BenHall-1 merged commit f219060 into master Mar 17, 2026
@BenHall-1 BenHall-1 deleted the RM-250 branch March 17, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants