Skip to content

Move pin notification messages deletion to event listener#74

Merged
BenHall-1 merged 9 commits intoTicketsBot-cloud:masterfrom
biast12:pins
Mar 1, 2026
Merged

Move pin notification messages deletion to event listener#74
BenHall-1 merged 9 commits intoTicketsBot-cloud:masterfrom
biast12:pins

Conversation

@biast12
Copy link
Copy Markdown
Contributor

@biast12 biast12 commented Dec 3, 2025

Description

Moves logic for deleting system pin notification messages from ticket opening to the message listener, ensuring pin notifications are automatically deleted in ticket channels. This simplifies the ticket opening process and centralizes pin notification cleanup.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • improvement

Testing

Be sure kafka works (this is to insure the event listener is being triggered)
Open a ticket, the notification should be deleted almost instantly

Checklist

  • My code follows the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Moves logic for deleting system pin notification messages from ticket opening to the message listener, ensuring pin notifications are automatically deleted in ticket channels. This simplifies the ticket opening process and centralizes pin notification cleanup.
@biast12 biast12 requested a review from a team as a code owner December 3, 2025 19:12
biast12 and others added 8 commits December 5, 2025 15:00
Replaces the generic bot author check with a specific comparison to the bot's ID when deleting pin notification messages in ticket channels. This ensures only messages from the current bot instance are considered for deletion.
@BenHall-1 BenHall-1 merged commit f660468 into TicketsBot-cloud:master Mar 1, 2026
BenHall-1 added a commit that referenced this pull request Mar 1, 2026
@biast12 biast12 deleted the pins branch March 8, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants