Skip to content

Conversation

@bobjoe12131
Copy link
Contributor

@bobjoe12131 bobjoe12131 commented Nov 15, 2025

Closes #100. The tilde character is for disabling CamelCase for a word, but it does not seem to have a use in the plugin.info file, and shows up in the description instead.

Should PRs with the tons of unrelated compiled JS be edited or rejected or something? Like, could i just slip in some obfuscated home dir deleter 9000 (or some other equivalent evil in browser code) in one of these large files, especially the "Load diff" files, and the reviewer either has to comb through each diff or possibly skip over an attack? Could some github bot take care of committing the compiled files instead of trusting and grouping the compilation in with other contributor PRs?

@bobjoe12131 bobjoe12131 marked this pull request as ready for review November 15, 2025 03:06
@Arlen22
Copy link
Member

Arlen22 commented Nov 16, 2025

Should PRs with the tons of unrelated compiled JS be edited or rejected or something? Like, could i just slip in some obfuscated home dir deleter 9000 (or some other equivalent evil in browser code) in one of these large files, especially the "Load diff" files, and the reviewer either has to comb through each diff or possibly skip over an attack? Could some github bot take care of committing the compiled files instead of trusting and grouping the compilation in with other contributor PRs?

I hadn't really thought about that much, but I'm moving to a different build system that builds those files when you run npm start and adds them to .gitignore. It should be in the latest commit. Rather than trying to mess around with rebasing or whatever it's called, I could just copy your changes in and commit them.

Arlen22 added a commit that referenced this pull request Nov 16, 2025
@bobjoe12131
Copy link
Contributor Author

Cool. I think you would use git rm and commit to the PR, but comparing doing that to using the web text editor for just a tilde and 5 spaces...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiWikiClient Plugin shows ~MultiWikiServer in ControlPanel

2 participants