Removed native journal CLI functionality in favor of external journal integrations#73
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Donna’s built-in journal CLI and session journal file handling, replacing it with an external “journal integration” mechanism that forwards internal JournalRecords to a configurable command ([journal].cmd). Documentation/specs are updated accordingly, and Taskwarrior-based helper scripts/config are added for this repository.
Changes:
- Removed
donna journalCLI commands and JSONL journal read/follow support. - Added workspace config support for
[journal].cmdand a new command-based journal writer (donna/workspaces/journal.py). - Updated README/spec fixtures/changelog and introduced Taskwarrior helper scripts + repo config.
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates docs to describe external journal integrations instead of donna journal view. |
| donna/workspaces/sessions.py | Removes session journal JSONL helpers and related imports. |
| donna/workspaces/journal.py | Adds external command-based journal writer with placeholder substitution. |
| donna/workspaces/initialization.py | Writes default config excluding None fields. |
| donna/workspaces/errors.py | Adds workspace errors for journal command config/execution failures. |
| donna/workspaces/config.py | Adds [journal].cmd config schema + placeholder validation. |
| donna/machine/sessions.py | Removes journal reset call during session start. |
| donna/machine/journal.py | Switches journal persistence from JSONL file to external command writer. |
| donna/machine/errors.py | Updates journaling error guidance text. |
| donna/machine/artifacts.py | Import formatting adjustment. |
| donna/fixtures/specs/usage/worlds.donna.md | Removes mention of internal journal storage under .donna/session. |
| donna/fixtures/specs/usage/cli.donna.md | Replaces journal CLI guidance with external integration guidance. |
| donna/fixtures/specs/intro.donna.md | Updates journaling section to internal records + external forwarding. |
| donna/cli/commands/journal.py | Deletes the journal CLI implementation. |
| donna/cli/commands/artifacts.py | Import formatting adjustment. |
| donna/cli/main.py | Stops importing/registering the removed journal CLI. |
| changes/unreleased.md | Documents removal of journal CLI and new journal.cmd guidance. |
| bin/taskwarior.sh | Adds Taskwarrior wrapper for structured journal logging. |
| bin/journal-follow.py | Adds a Taskwarrior-backed “follow” view for journal records. |
| AGENTS.md | Updates agent instructions to use Taskwarrior as the journal mechanism. |
| .taskrc | Adds Taskwarrior configuration for repo-local journal data/UDAs. |
| .donna/config.toml | Enables forwarding internal journal records to the Taskwarrior wrapper. |
| .agents/skills/session/SKILL.md | Adds skill spec for using .session/ for temporary files and session resets. |
| .agents/donna/usage/worlds.donna.md | Mirrors spec update removing internal journal storage mention. |
| .agents/donna/usage/cli.donna.md | Mirrors spec update removing journal CLI guidance. |
| .agents/donna/intro.donna.md | Mirrors spec update for internal journaling + external forwarding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+82
| try: | ||
| result = subprocess.run(args, check=False, capture_output=True, text=True) # noqa: S603 | ||
| except OSError as e: |
Comment on lines
+90
to
91
| workspace_journal.write_record(record).unwrap() | ||
| instant_output_journal(record) |
| @@ -0,0 +1,2 @@ | |||
| [journal] | |||
| cmd = ["./bin/taskwarior.sh", "log", "+journal", "+donna", "kind:event", "{message}"] | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.