Skip to content

Conversation

@reggna
Copy link
Collaborator

@reggna reggna commented Apr 6, 2025

The default setting generated for Titlegiver is simply:

"titlegiver": {}

This however fails in Titlegiver.process when checking

if parts.netloc in self.settings["blacklist"]

So, let's just make the setting optional.

The default setting generated for Titlegiver is simply:

"titlegiver": {}

This however fails in Titlegiver.process when checking

if parts.netloc in self.settings["blacklist"]

So, let's just make the setting optional.
@reggna reggna merged commit abc4174 into main Apr 6, 2025
13 of 19 checks passed
@reggna reggna deleted the fix_titlegiver_default_settings branch April 6, 2025 23:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14287016644

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.2%) to 62.468%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/titlegiver/titlegiver.py 0 2 0.0%
Totals Coverage Status
Change from base Build 14278788294: 4.2%
Covered Lines: 1205
Relevant Lines: 1929

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants