Skip to content

Fix double registration #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fix double registration #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10a2dc3
Fix registration
ktsitsi Apr 3, 2023
43da22e
Completely removing post-create registration
ktsitsi Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions tiledb/bioimg/converters/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
from __future__ import annotations

import json
import os
import warnings
from abc import ABC, abstractmethod
from concurrent.futures import ThreadPoolExecutor
from operator import itemgetter
from typing import Any, Dict, Mapping, Optional, Sequence, Tuple, Type, Union
from urllib.parse import urlparse

import numpy as np
from tqdm import tqdm
Expand Down Expand Up @@ -173,7 +171,6 @@ def to_tiledb(
chunked: bool = False,
max_workers: int = 0,
compressor: tiledb.Filter = tiledb.ZstdFilter(level=0),
register_kwargs: Mapping[str, Any] = {},
reader_kwargs: Mapping[str, Any] = {},
pyramid_kwargs: Optional[Mapping[str, Any]] = None,
) -> None:
Expand All @@ -194,8 +191,6 @@ def to_tiledb(
:param max_workers: Maximum number of threads that can be used for conversion.
Applicable only if chunked=True.
:param compressor: TileDB compression filter
:param register_kwargs: Cloud group registration optional args e.g namespace,
parent_uri, storage_uri, credentials_name
:param reader_kwargs: Keyword arguments passed to the _ImageReaderType constructor.
:param pyramid_kwargs: Keyword arguments passed to the scaler constructor for
generating downsampled versions of the base level. Valid keyword arguments are:
Expand Down Expand Up @@ -281,9 +276,6 @@ def to_tiledb(
),
)

if register_group is not None and urlparse(output_path).scheme == "tiledb":
register_group(name=os.path.basename(output_path), **register_kwargs)


def _convert_level_to_tiledb(
level: int,
Expand Down