Dstara/updates #10
Merged
Dstara/updates #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
reviewed
Oct 24, 2022
| /** | ||
| * Exec an SQL query and get results in arrow format. | ||
| * | ||
| * @return |
Member
There was a problem hiding this comment.
Can you add a comment on this return type?
Shelnutt2
approved these changes
Oct 24, 2022
Member
Shelnutt2
left a comment
Shelnutt2
left a comment
There was a problem hiding this comment.
One minor comment, then lgtm! Great work!
DimitrisStaratzis
force-pushed
the
dstara/updates
branch
from
513e62d to
c702bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary changes for the JDBC connector.