Skip to content

Dstara/api improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DimitrisStaratzis merged 7 commits into from
Sep 28, 2023
Merged

Dstara/api improvements #17

DimitrisStaratzis merged 7 commits into from
Sep 28, 2023

Conversation

@DimitrisStaratzis
Copy link
Contributor

@DimitrisStaratzis DimitrisStaratzis commented Sep 28, 2023 •
edited
Loading

This PR improves the API and adds an initial CI.

@DimitrisStaratzis DimitrisStaratzis marked this pull request as draft September 28, 2023 13:59
@DimitrisStaratzis DimitrisStaratzis marked this pull request as ready for review September 28, 2023 14:30
ihnorton
ihnorton approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question, LGTM

@DimitrisStaratzis DimitrisStaratzis merged commit d11170e into master Sep 28, 2023
@DimitrisStaratzis DimitrisStaratzis deleted the dstara/API_improvements branch September 28, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihnorton ihnorton ihnorton approved these changes

@Shelnutt2 Shelnutt2 Awaiting requested review from Shelnutt2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DimitrisStaratzis @ihnorton