add login with 'remember me' option by storing data in $home/.tiledb/cloud.json #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22111: Support cloud config file.. |
Shelnutt2
reviewed
Oct 6, 2022
.openapi-generator-ignore
Outdated
| settings.gradle | ||
|
|
||
| #the api client contains the custom code for static initialization from the json file | ||
| src/main/java/io/tiledb/cloud/rest_api/ApiClient.java |
Member
There was a problem hiding this comment.
I don't think we should override generated classes. Can we take the approach we had in TileDB-Cloud-Py in that we create higher level classes that wrap the generated API?
Contributor
Author
There was a problem hiding this comment.
Created the TileDBClient class to wrap the autogenerated one
Shelnutt2
approved these changes
Oct 6, 2022
Member
Shelnutt2
left a comment
Shelnutt2
left a comment
There was a problem hiding this comment.
Great work! One question then lgtm.
| @@ -0,0 +1,73 @@ | |||
| package io.tiledb.cloud.rest_api; | |||
Member
There was a problem hiding this comment.
Should we move this up a level so we keep autogenerated in a separate package?
DimitrisStaratzis
deleted the
dimitrisstaratzis/sc-22111/support-cloud-config-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables TileDB-Cloud-Java to use
$home/.tiledb/cloud.jsonto store login information.To achieve that I created a new Login class. This class is used the first time someone wants to login. This Login class takes as input all credentials and server settings required and has two additional options.
RememberMe: if true, it will store the credentials in$home/.tiledb/cloud.jsonfor future use.OverwritePrevious: If true, it will favor the new input credentials over the saved ones. In combination withRememberMeit can be used to overwrite the data in$home/.tiledb/cloud.jsonIn Addition I created the TileDBClient class to wrap the ApiClient class, similarly to what we do in python and R to avoid modifying auto-generated classes.
Loading the credentials is done by statically initiallizing the
TileDBClientclass.Note: See updated example file for details.