Dimitrisstaratzis/sc 22112/support arrow return type for serverless #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22112: Support arrow return type for serverless SQL. |
Shelnutt2
approved these changes
Oct 18, 2022
| throw new RuntimeException(e); | ||
| } | ||
| } catch (ApiException e) { | ||
| System.err.println("Exception when calling SqlApi#runSQL/runSQLBytes"); |
Member
There was a problem hiding this comment.
In a follow up we should find a way to return these errors better to the user.
DimitrisStaratzis
deleted the
dimitrisstaratzis/sc-22112/support-arrow-return-type-for-serverless
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have also included a file named
CustomCode.txt. it contains the additions that are needed in the auto generated files. I have not figured out how to automate the process after every generation, but will do it in a different PR. For now I just keep a log.