Bind multi range query API #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @throws TileDBError A TileDB exception | ||
| */ | ||
| public Query addRange(int dimIdx, Object start, Object end) throws TileDBError { | ||
| Datatype dimType = array.getSchema().getDomain().getType(); |
Contributor
There was a problem hiding this comment.
you need to wrap these in a try block as well
try (Schema schema = array.getSchema(); Domain = schema.getDomain()) {}`
| * @throws TileDBError A TileDB exception | ||
| */ | ||
| public Pair<Object, Object> getRange(int dimIdx, long rangeIdx) throws TileDBError { | ||
| Datatype dimType = array.getSchema().getDomain().getType(); |
tdenniston
force-pushed
the
tylerdenniston/ch434/bind-multi-range-queries
branch
from
e9a8883 to
b7b1b3f
Compare
Contributor
Author
|
Thanks @jakebolewski ! Fixed those two issues |
Contributor
|
LGTM |
tdenniston
force-pushed
the
tylerdenniston/ch434/bind-multi-range-queries
branch
from
b7b1b3f to
b7958c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.